Add valueinfos field to FunctionProto #5903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
justinchuby
reviewed
Feb 2, 2024
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
justinchuby
reviewed
Feb 2, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5903 +/- ##
=======================================
Coverage 56.65% 56.65%
=======================================
Files 506 506
Lines 30193 30196 +3
Branches 4555 4556 +1
=======================================
+ Hits 17105 17107 +2
Misses 12266 12266
- Partials 822 823 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
justinchuby
approved these changes
Feb 2, 2024
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
This was referenced Feb 6, 2024
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description * Extend FunctionProto by adding a field to store ValueInfos for variables in the function. * Extend the helper function and parser to support this. ### Motivation and Context This enables type/shape information to be stored for variables in a FunctionProto, just like in a GraphProto. Note that this is optional, just like in a graph. This field may store type/shape info for the inputs and outputs of a function as well. (Note that, unlike in a graph, the input/output field in a FunctionProto do not have explicit types/shapes, they are just strings, not ValueInfo.) --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This enables type/shape information to be stored for variables in a FunctionProto, just like in a GraphProto. Note that this is optional, just like in a graph. This field may store type/shape info for the inputs and outputs of a function as well. (Note that, unlike in a graph, the input/output field in a FunctionProto do not have explicit types/shapes, they are just strings, not ValueInfo.)