Bump Numpy minimal version to 1.20 #5902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onnx#5900 Fix Linux release pipeline due to usage of np.broadcast_shapes which was introduced in numpy==1.20.0 Signed-off-by: Gal Hubara Agam <ghubaraagam@nvidia.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5902 +/- ##
=======================================
Coverage 56.65% 56.65%
=======================================
Files 506 506
Lines 30192 30192
Branches 4555 4555
=======================================
Hits 17104 17104
Misses 12266 12266
Partials 822 822 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
liqunfu
approved these changes
Feb 2, 2024
justinchuby
approved these changes
Feb 2, 2024
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description Fix Linux release pipeline due to usage of np.broadcast_shapes which was introduced in numpy==1.20.0 ### Motivation and Context Fix onnx#5900 --------- Signed-off-by: Gal Hubara Agam <ghubaraagam@nvidia.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Linux release pipeline due to usage of np.broadcast_shapes which was introduced in numpy==1.20.0
Motivation and Context
Fix #5900