Fix label encoder definition in schema #5863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5863 +/- ##
=======================================
Coverage 56.45% 56.45%
=======================================
Files 504 504
Lines 29868 29868
Branches 4488 4488
=======================================
Hits 16863 16863
Misses 12188 12188
Partials 817 817 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
79d65b4 to
29f119c
Compare
xadupre
approved these changes
Jan 25, 2024
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description The use of the `OpSchema::Attr` with conditionExplanation ends up having a default AttributeProto without a TensorProto field. The `default_tensor` attribute is optional and so should not be setting a default value. cc @gramalingam ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> Signed-off-by: Aditya Goel <agoel4512@gmail.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The use of the
OpSchema::Attrwith conditionExplanation ends up having a default AttributeProto without a TensorProto field. Thedefault_tensorattribute is optional and so should not be setting a default value.cc @gramalingam
Motivation and Context