Skip some int4 test with old numpy version #5858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5858 +/- ##
=======================================
Coverage 56.45% 56.45%
=======================================
Files 504 504
Lines 29865 29868 +3
Branches 4484 4488 +4
=======================================
+ Hits 16860 16863 +3
Misses 12188 12188
Partials 817 817 ☔ View full report in Codecov by Sentry. |
xadupre
approved these changes
Jan 16, 2024
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Merged
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description some int4 tests requires numpy version higher than 1.22.0 for support of elementwise operations on numpy arrays of custom dtypes. release CIs have test of old numpy versions and thus failed. ### Motivation and Context make release CI to pass. --------- Signed-off-by: Liqun Fu <liqfu@microsoft.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
some int4 tests requires numpy version higher than 1.22.0 for support of elementwise operations on numpy arrays of custom dtypes. release CIs have test of old numpy versions and thus failed.
Motivation and Context
make release CI to pass.