Skip to content

Add perm length constraint in Transpose doc #5857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2024
Merged

Add perm length constraint in Transpose doc #5857

merged 1 commit into from
Jan 16, 2024

Conversation

isdanni
Copy link
Contributor

@isdanni isdanni commented Jan 14, 2024

fix #5481

@isdanni isdanni requested a review from a team as a code owner January 14, 2024 23:47
@isdanni isdanni force-pushed the doc-perm-transpose branch 3 times, most recently from 576de2d to 58ac0a0 Compare January 15, 2024 00:27
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f1c59a5) 56.45% compared to head (fd98b95) 56.45%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5857   +/-   ##
=======================================
  Coverage   56.45%   56.45%           
=======================================
  Files         504      504           
  Lines       29865    29865           
  Branches     4484     4484           
=======================================
  Hits        16860    16860           
  Misses      12188    12188           
  Partials      817      817

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isdanni isdanni force-pushed the doc-perm-transpose branch 3 times, most recently from 9bf733c to 8956000 Compare January 15, 2024 01:06
xadupre
xadupre reviewed Jan 15, 2024
View reviewed changes
@isdanni
Add length constraint in Transpose doc
fd98b95 
Signed-off-by: isdanni <leedanni@gmail.com>
@isdanni isdanni force-pushed the doc-perm-transpose branch from 2028509 to fd98b95 Compare January 15, 2024 18:17
@xadupre xadupre enabled auto-merge January 16, 2024 08:49
@xadupre xadupre added this pull request to the merge queue Jan 16, 2024
@justinchuby
Copy link
Member

Thank you!

Merged via the queue into onnx:main with commit 54e704e Jan 16, 2024
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
@isdanni @linshokaku
Add perm length constraint in Transpose doc (onnx#5857)
a735ada 
fix onnx#5481

Signed-off-by: isdanni <leedanni@gmail.com>
Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xadupre xadupre xadupre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document perm in Transpose need to have the same length as the input rank
3 participants
@isdanni @justinchuby @xadupre