Skip to content

Use mac-release 10.15 #5820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Use mac-release 10.15 #5820

merged 4 commits into from
Dec 22, 2023

Conversation

liqunfu
Copy link
Collaborator

@liqunfu liqunfu commented Dec 22, 2023

Description

release build breaks due to #5806
filesystem not available on Mac 10.12.
also need to skip 2 reference implement tests (test_qlinearmatmul_3D_int8_float16_cpu, test_qlinearmatmul_3D_int8_float32_cpu) which are failing on MacOS (#5792)

Motivation and Context

fix mac release CI

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu liqunfu requested a review from a team as a code owner December 22, 2023 08:29
@liqunfu liqunfu added the run release CIs Use this label to trigger release tests in CI label Dec 22, 2023
@liqunfu liqunfu closed this Dec 22, 2023
@liqunfu liqunfu reopened this Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8e61b60) 56.37% compared to head (41b04a9) 56.36%.

Files Patch % Lines
onnx/test/test_backend_reference.py 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5820      +/-   ##
==========================================
- Coverage   56.37%   56.36%   -0.01%     
==========================================
  Files         503      503              
  Lines       29591    29594       +3     
  Branches     4423     4424       +1     
==========================================
  Hits        16682    16682              
- Misses      12105    12107       +2     
- Partials      804      805       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@justinchuby justinchuby changed the title use mac-release 10.15 Use mac-release 10.15 Dec 22, 2023
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby added this pull request to the merge queue Dec 22, 2023
Merged via the queue into main with commit a66b596 Dec 22, 2023
@justinchuby justinchuby deleted the liqun/mac-10.15 branch December 22, 2023 15:41
wplf pushed a commit to wplf/onnx that referenced this pull request Jan 3, 2024
### Description
release build breaks due to onnx#5806
filesystem not available on Mac 10.12.
also need to skip 2 reference implement tests
(test_qlinearmatmul_3D_int8_float16_cpu,
test_qlinearmatmul_3D_int8_float32_cpu) which are failing on MacOS
(onnx#5792)

### Motivation and Context
fix mac release CI

---------

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: wplf <975761915@qq.com>
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
### Description
release build breaks due to onnx#5806
filesystem not available on Mac 10.12.
also need to skip 2 reference implement tests
(test_qlinearmatmul_3D_int8_float16_cpu,
test_qlinearmatmul_3D_int8_float32_cpu) which are failing on MacOS
(onnx#5792)

### Motivation and Context
fix mac release CI

---------

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run release CIs Use this label to trigger release tests in CI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants