Removed unused string_view include #5813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lavrenov <ilya.lavrenov@intel.com>
bbe9b26 to
fb55591
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5813 +/- ##
=======================================
Coverage 56.36% 56.36%
=======================================
Files 503 503
Lines 29634 29634
Branches 4435 4435
=======================================
Hits 16702 16702
Misses 12120 12120
Partials 812 812 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Dec 18, 2023
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description Without C++17 current codebase cannot be compiled. But it seems that `string_view` include is not used and we can drop it. Signed-off-by: Ilya Lavrenov <ilya.lavrenov@intel.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without C++17 current codebase cannot be compiled.
But it seems that
string_viewinclude is not used and we can drop it.