Skip to content

Support Unicode file paths when loading an ONNX file #5806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 15, 2023
Merged

Support Unicode file paths when loading an ONNX file #5806

merged 13 commits into from
Dec 15, 2023

Conversation

captainIT
Copy link
Contributor

@captainIT captainIT commented Dec 14, 2023 •
edited by justinchuby
Loading

Description

Support Unicode file paths when loading an ONNX file.

Motivation and Context

Fix #5761

@captainIT captainIT requested a review from a team as a code owner December 14, 2023 08:55
@captainIT captainIT mentioned this pull request Dec 14, 2023
Closed
@captainIT
Copy link
Contributor Author

fix #5761

@justinchuby justinchuby self-assigned this Dec 14, 2023
@justinchuby justinchuby changed the title fix windows unicode onnx-name error Fix windows unicode onnx-name error Dec 14, 2023
justinchuby
justinchuby reviewed Dec 14, 2023
View reviewed changes
@justinchuby
Copy link
Member

Please follow https://github.com/onnx/onnx/pull/5806/checks?check_run_id=19631633187 to signoff your commits. Thank you for your contribution!

justinchuby
justinchuby reviewed Dec 14, 2023
View reviewed changes
justinchuby
justinchuby reviewed Dec 15, 2023
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Dec 15, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c92866c) 56.34% compared to head (1d2db4d) 56.36%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5806      +/-   ##
==========================================
+ Coverage   56.34%   56.36%   +0.01%     
==========================================
  Files         503      503              
  Lines       29622    29634      +12     
  Branches     4434     4435       +1     
==========================================
+ Hits        16690    16702      +12     
  Misses      12120    12120              
  Partials      812      812

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xadupre and others added 8 commits December 15, 2023 12:49
@xadupre @captainIT
Update diff2html to support dark theme when showing operator differen…
3866af2 
…ces (#5795)

### Description
The page showing differences between two operators is not readable in
dark mode. diff2html was recently updated to fix this issue.

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: captainIT <captainlin205@gmail.com>
@xadupre @captainIT
Fix conversion to zero for E4M3FNUZ and E5M2FNUZ (#5764)
b0c7228 
### Description
-0.00001 must be converted into 0 and not negative zero which does not
exist for types Float8E4M3FNUZ and Float8E5M2UZ.
See microsoft/onnxruntime#18473 for further
details.

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: captainIT <captainlin205@gmail.com>
@cjvolzka @captainIT
Replace sanity with saftey for inclusive terminology (#5802)
4ad061d 
### Description
Replace "sanity" with "safety".

### Motivation and Context
Inclusive terminology change

Signed-off-by: Charles Volzka <cjvolzka@us.ibm.com>
Signed-off-by: captainIT <captainlin205@gmail.com>
@captainIT
fix windows unicode onnx-name error
d1583ee 
Signed-off-by: zhangxinlin <you@example.com>
Signed-off-by: captainIT <captainlin205@gmail.com>
@captainIT
add include filesystem
ae75b03 
Signed-off-by: zhangxinlin <you@example.com>
Signed-off-by: captainIT <captainlin205@gmail.com>
@captainIT
add a unit test
802c708 
Signed-off-by: captainIT <captainlin205@gmail.com>
@captainIT
add a unit test
3341d66 
Signed-off-by: captainIT <captainlin205@gmail.com>
@captainIT
fix use tempfile
fc52cbb 
Signed-off-by: captainIT <captainlin205@gmail.com>
@captainIT captainIT requested a review from a team as a code owner December 15, 2023 04:59
justinchuby
justinchuby reviewed Dec 15, 2023
View reviewed changes
Copy link
Member

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Final round of comments

captainIT and others added 2 commits December 15, 2023 14:14
@captainIT
1、Avoid non global imports
1215d1f 
2、cover cjk and emoji

Signed-off-by: captainIT <captainlin205@gmail.com>
@justinchuby
Update checker_test.py
6231235 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby

This comment was marked as resolved.

Sign in to view
@justinchuby
Update file_utils.h
fe5330f 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update checker_test.py
1d2db4d 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby removed their assignment Dec 15, 2023
@justinchuby justinchuby changed the title Fix windows unicode onnx-name error Support Unicode file paths when loading an ONNX file Dec 15, 2023
@justinchuby justinchuby added this pull request to the merge queue Dec 15, 2023
Merged via the queue into onnx:main with commit 67c456b Dec 15, 2023
@liqunfu liqunfu mentioned this pull request Dec 22, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 22, 2023
@liqunfu @justinchuby
Use mac-release 10.15 (#5820)
a66b596 
### Description
release build breaks due to #5806
filesystem not available on Mac 10.12.
also need to skip 2 reference implement tests
(test_qlinearmatmul_3D_int8_float16_cpu,
test_qlinearmatmul_3D_int8_float32_cpu) which are failing on MacOS
(#5792)

### Motivation and Context
fix mac release CI

---------

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
wplf pushed a commit to wplf/onnx that referenced this pull request Jan 3, 2024
@liqunfu @justinchuby @wplf
Use mac-release 10.15 (onnx#5820)
50a1d12 
### Description
release build breaks due to onnx#5806
filesystem not available on Mac 10.12.
also need to skip 2 reference implement tests
(test_qlinearmatmul_3D_int8_float16_cpu,
test_qlinearmatmul_3D_int8_float32_cpu) which are failing on MacOS
(onnx#5792)

### Motivation and Context
fix mac release CI

---------

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: wplf <975761915@qq.com>
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
@captainIT @xadupre
@cjvolzka @justinchuby @linshokaku
Support Unicode file paths when loading an ONNX file (onnx#5806)
ce2bdec 
### Description

Support Unicode file paths when loading an ONNX file.

### Motivation and Context

Fix onnx#5761

---------

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: captainIT <captainlin205@gmail.com>
Signed-off-by: Charles Volzka <cjvolzka@us.ibm.com>
Signed-off-by: zhangxinlin <you@example.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Co-authored-by: Xavier Dupré <xadupre@users.noreply.github.com>
Co-authored-by: Charles Volzka <42243335+cjvolzka@users.noreply.github.com>
Co-authored-by: zhangxinlin <you@example.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Linsho Kaku <linsho@preferred.jp>
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
@liqunfu @justinchuby @linshokaku
Use mac-release 10.15 (onnx#5820)
5a7713c 
### Description
release build breaks due to onnx#5806
filesystem not available on Mac 10.12.
also need to skip 2 reference implement tests
(test_qlinearmatmul_3D_int8_float16_cpu,
test_qlinearmatmul_3D_int8_float32_cpu) which are failing on MacOS
(onnx#5792)

### Motivation and Context
fix mac release CI

---------

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

@gramalingam gramalingam Awaiting requested review from gramalingam

Assignees

@gramalingam gramalingam

Labels
None yet
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Unicode characters in proto paths
5 participants
@captainIT @justinchuby @gramalingam @xadupre @cjvolzka