Replace sanity with saftey for inclusive terminology #5802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles Volzka <cjvolzka@us.ibm.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5802 +/- ##
=======================================
Coverage 56.34% 56.34%
=======================================
Files 503 503
Lines 29622 29622
Branches 4434 4434
=======================================
Hits 16690 16690
Misses 12120 12120
Partials 812 812 ☔ View full report in Codecov by Sentry. |
|
Thanks for the change! Do we have a guidance on inclusive language use? To me “soundness” seems to carry a closer meaning than “safety” as the intended. As “safety” often mean the lack of exploits or being safe in program behavior imo. |
|
In IBM we generally move "sanity" to "safety" by default but it's not required. If the ONNX community has a preference to another term, I'm happy to switch to that. I've seen other repos go with "smoke tests" too. |
|
@onnx/sig-operators-approvers to chime in |
gramalingam
approved these changes
Dec 14, 2023
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description Replace "sanity" with "safety". ### Motivation and Context Inclusive terminology change Signed-off-by: Charles Volzka <cjvolzka@us.ibm.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace "sanity" with "safety".
Motivation and Context
Inclusive terminology change