Resurrect check function context logic #5778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5778 +/- ##
=======================================
Coverage 56.33% 56.34%
=======================================
Files 503 503
Lines 29626 29626
Branches 4436 4438 +2
=======================================
+ Hits 16691 16692 +1
+ Misses 12120 12119 -1
Partials 815 815 ☔ View full report in Codecov by Sentry. |
gramalingam
approved these changes
Nov 30, 2023
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description Resurrect check function context logic to handle when context is not provided to `check_function`. We need to support None because otherwise `check_function` breaks backward compatibility when only the first argument is provided. ### Motivation and Context Fix onnx#5774 --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resurrect check function context logic to handle when context is not provided to
check_function. We need to support None because otherwisecheck_functionbreaks backward compatibility when only the first argument is provided.Motivation and Context
Fix #5774