Enable unity(Jumbo) builds #5768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Simon Lapointe <jean-simon.lapointe@ubisoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5768 +/- ##
=======================================
Coverage 56.39% 56.39%
=======================================
Files 503 503
Lines 29620 29620
Branches 4426 4426
=======================================
Hits 16704 16704
Misses 12109 12109
Partials 807 807 ☔ View full report in Codecov by Sentry. |
xadupre
reviewed
Nov 23, 2023
xadupre
reviewed
Nov 23, 2023
xadupre
reviewed
Nov 23, 2023
xadupre
reviewed
Nov 23, 2023
Signed-off-by: Jean-Simon Lapointe <jean-simon.lapointe@ubisoft.com>
|
Also, I think it would be best to have at least one unity build part of the CI process, to make sure it does not get broken. Do you think it is something we could do? If so, how? |
justinchuby
approved these changes
Dec 21, 2023
justinchuby
reviewed
Dec 21, 2023
Signed-off-by: Jean-Simon Lapointe <jean-simon.lapointe@ubisoft.com>
gramalingam
approved these changes
Jan 4, 2024
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
Added a cmake option to enable Unity builds. Added missing include guards Fixed some missing/extra #undef that cause Unity builds to fail. Fixed some duplicated symbol names that made Unity builds to fail For large code base, especially in the game dev industry, Unity builds (https://en.wikipedia.org/wiki/Unity_build) are used to speed up the compilations. Special care must be taken to enable Unity builds for a project, since many translation units will be merged togheter. --------- Signed-off-by: Jean-Simon Lapointe <jean-simon.lapointe@ubisoft.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a cmake option to enable Unity builds.
Added missing include guards
Fixed some missing/extra #undef that cause Unity builds to fail.
Fixed some duplicated symbol names that made Unity builds to fail
Motivation and Context
For large code base, especially in the game dev industry, Unity builds (https://en.wikipedia.org/wiki/Unity_build) are used to speed up the compilations.
Special care must be taken to enable Unity builds for a project, since many translation units will be merged togheter.