Fix conversion to zero for E4M3FNUZ and E5M2FNUZ #5764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5764 +/- ##
=======================================
Coverage 56.34% 56.34%
=======================================
Files 503 503
Lines 29626 29622 -4
Branches 4438 4434 -4
=======================================
- Hits 16692 16690 -2
- Misses 12119 12120 +1
+ Partials 815 812 -3 ☔ View full report in Codecov by Sentry. |
justinchuby
reviewed
Nov 28, 2023
justinchuby
approved these changes
Nov 28, 2023
gramalingam
approved these changes
Dec 4, 2023
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description -0.00001 must be converted into 0 and not negative zero which does not exist for types Float8E4M3FNUZ and Float8E5M2UZ. See microsoft/onnxruntime#18473 for further details. Signed-off-by: Xavier Dupre <xadupre@microsoft.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-0.00001 must be converted into 0 and not negative zero which does not exist for types Float8E4M3FNUZ and Float8E5M2UZ.
See microsoft/onnxruntime#18473 for further details.