Skip to content

Add default for check_function & Use lexical_scope_ctx for readability #5757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

Add default for check_function & Use lexical_scope_ctx for readability #5757

merged 1 commit into from
Nov 14, 2023

Conversation

isdanni
Copy link
Contributor

@isdanni isdanni commented Nov 14, 2023 •
edited
Loading

Description

  • Use lexical_scope_ctx instead of ctx in checker.py
  • Provide default contexts in check_function()

Motivation and Context

Follow up to #5693

Close #5755

@isdanni isdanni requested a review from a team as a code owner November 14, 2023 04:18
@isdanni isdanni force-pushed the lexical-scope-ctx-followup branch from 015a7ec to 92bce7f Compare November 14, 2023 04:19
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab5bdf8) 56.06% compared to head (92bce7f) 56.06%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5757   +/-   ##
=======================================
  Coverage   56.06%   56.06%           
=======================================
  Files         501      501           
  Lines       29366    29366           
  Branches     4404     4404           
=======================================
  Hits        16463    16463           
  Misses      12091    12091           
  Partials      812      812

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

justinchuby
justinchuby approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚢

@justinchuby justinchuby added this pull request to the merge queue Nov 14, 2023
Merged via the queue into onnx:main with commit ede2c77 Nov 14, 2023
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
@isdanni @linshokaku
Add default for check_function & Use lexical_scope_ctx for readability (
9345b2b 
onnx#5757)

### Description

- Use `lexical_scope_ctx` instead of `ctx` in `checker.py`
- Provide default contexts in `check_function()`

### Motivation and Context
Follow up to onnx#5693

Close onnx#5755

Signed-off-by: isdanni <leedanni@gmail.com>
Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check_function requires contexts as arguments which breaks backward compatibility
2 participants
@isdanni @justinchuby