Make ReferenceEvaluator support ModelContainer #5754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5754 +/- ##
==========================================
+ Coverage 56.06% 56.16% +0.10%
==========================================
Files 501 502 +1
Lines 29366 29454 +88
Branches 4404 4414 +10
==========================================
+ Hits 16463 16544 +81
- Misses 12091 12095 +4
- Partials 812 815 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
justinchuby
reviewed
Nov 15, 2023
justinchuby
reviewed
Nov 15, 2023
justinchuby
reviewed
Nov 15, 2023
justinchuby
reviewed
Nov 15, 2023
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
justinchuby
reviewed
Nov 15, 2023
justinchuby
approved these changes
Nov 15, 2023
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description ReferenceEvaluator can take any proto as an input. This PR extends the support to ModelContainer introduced in PR onnx#5685. ### Motivation and Context This makes it easier to test. --------- Signed-off-by: Xavier Dupre <xadupre@microsoft.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ReferenceEvaluator can take any proto as an input. This PR extends the support to ModelContainer introduced in PR #5685.
Motivation and Context
This makes it easier to test.