update release doc for tag creation #5721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
justinchuby
approved these changes
Oct 31, 2023
isdanni
pushed a commit
to isdanni/onnx
that referenced
this pull request
Nov 2, 2023
### Description To re-order release steps so that release branch is created before release tag is to be created. This is because release branch is needed for creating a tag. ### Motivation and Context TO reduce mistake of creating a release tag with in-correct branch Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To re-order release steps so that release branch is created before release tag is to be created. This is because release branch is needed for creating a tag.
Motivation and Context
TO reduce mistake of creating a release tag with in-correct branch