Skip to content

Conversation

liqunfu
Copy link
Collaborator

@liqunfu liqunfu commented Oct 4, 2023

Description

doc for affineGrid: output shape is in correct. See https://pytorch.org/docs/stable/generated/torch.nn.functional.affine_grid.html. It shoud be (N, H, W, 2) or (N, D, H, W, 3)

Motivation and Context

fix for 1.15.0 release

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu liqunfu added this to the 1.15 milestone Oct 4, 2023
@liqunfu liqunfu requested a review from a team as a code owner October 4, 2023 17:27
@justinchuby justinchuby changed the title fix affineGrid doc error - output shape shall has no 'C' in it Fix affineGrid doc error - output shape shall has no 'C' in it Oct 4, 2023
@justinchuby justinchuby added the topic: operator Issues related to ONNX operators label Oct 4, 2023
@justinchuby
Copy link
Member

Was shape inferenced updated too? Just making sure. Thanks!

@gramalingam gramalingam added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit b702c4e Oct 5, 2023
@gramalingam gramalingam deleted the liqun/onnx-affinegrid-doc-err branch October 5, 2023 17:04
liqunfu added a commit that referenced this pull request Oct 17, 2023
### Description
doc for affineGrid: output shape is in correct. See
https://pytorch.org/docs/stable/generated/torch.nn.functional.affine_grid.html.
It shoud be (N, H, W, 2) or (N, D, H, W, 3)

### Motivation and Context
fix for 1.15.0 release

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: operator Issues related to ONNX operators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants