Fix version-converter to generate valid identifiers #5628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
justinchuby
approved these changes
Sep 29, 2023
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
### Description #5628 missed some getNextUnique() and causes name conflict. Signed-off-by: daquexian <daquexian566@gmail.com>
cjvolzka
added a commit
that referenced
this pull request
Mar 4, 2024
isdanni
pushed a commit
to isdanni/onnx
that referenced
this pull request
Mar 18, 2024
### Description onnx#5628 missed some getNextUnique() and causes name conflict. Signed-off-by: daquexian <daquexian566@gmail.com> Signed-off-by: isdanni <leedanni@gmail.com>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description onnx#5628 missed some getNextUnique() and causes name conflict. Signed-off-by: daquexian <daquexian566@gmail.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The version-converter generates invalid ONNX identifiers (like "1"). Change it to generate a valid identifier.