Clarify cond to If must contain a single element
#5617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
justinchuby
commented
Sep 23, 2023
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
commented
Sep 23, 2023
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
commented
Sep 23, 2023
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
cond to If must contain a single elementcond to If must contain a single element
jcwchen
reviewed
Sep 23, 2023
gramalingam
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Thanks for the update.
I created an issue #5622 to discuss the other aspect (whether the shape of the condition is required to be empty or if it can be anything, also in general for this and other similar ops).
But this seems fine for now.
Since the shape may be unknown I am not sure if the check is robust. I can do this as a follow up. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clarify
condtoIfmust contain a single element. Previously it is unclear what the condition can be.Fix reference runtime accordingly.
Motivation and Context
Fixes #5520