Skip to content

Updated docs for DynamicQuantizeLinear to be consistent with reference implementation #5603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2023
Merged

Updated docs for DynamicQuantizeLinear to be consistent with reference implementation #5603

merged 3 commits into from
Sep 25, 2023

Conversation

Swopper050
Copy link
Contributor

Hi! Something went wrong with my other pull request (#5601), so I forked the right version and tried again:

Description

I changed the operator definition for DynamicQuantizeLinear to be consistent with the reference implementation as described in #5597

Motivation and Context

#5597

@Swopper050
Updated docs to be consistent with reference implementation
a253099 
Signed-off-by: Swopper050 <bram@witoos.nl>
@Swopper050 Swopper050 requested a review from a team as a code owner September 20, 2023 10:23
@Swopper050 Swopper050 mentioned this pull request Sep 20, 2023
Closed
@Swopper050 Swopper050 changed the title Updated docs to be consistent with reference implementation Updated docs for DynamicQuantizeLinear to be consistent with reference implementation Sep 20, 2023
@Swopper050
Copy link
Contributor Author

@jcwchen Could you take another look? :)

@jcwchen jcwchen added topic: documentation Issues related to ONNX documentation auto update doc Generate md/proto files automatically using the CI pipeline labels Sep 20, 2023
@jcwchen
Copy link
Member

jcwchen commented Sep 20, 2023

Please allow me to reopen this PR for retriggering auto update doc CI.

@jcwchen jcwchen closed this Sep 20, 2023
@jcwchen jcwchen reopened this Sep 20, 2023
@jcwchen @github-actions
CI:apply auto updated documentation
acd2f0a 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jcwchen
jcwchen reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@jcwchen jcwchen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new PR and now the documents have been updated accordingly by CI. I will take care of Windows CI failure in another PR.

@Swopper050
Copy link
Contributor Author

Awesome, thanks! Is there anything I can still do for this issue/PR?

@jcwchen jcwchen removed the auto update doc Generate md/proto files automatically using the CI pipeline label Sep 20, 2023
jcwchen
jcwchen approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with this change, but it will need approval from @onnx/sig-operators-approvers. Could @onnx/sig-operators-approvers please review this PR? Thanks.

@jcwchen jcwchen linked an issue Sep 20, 2023 that may be closed by this pull request
DynamicQuantizeLinear - Documentation example and reference mismatch #5597
Closed
@xadupre xadupre added this pull request to the merge queue Sep 25, 2023
Merged via the queue into onnx:main with commit 09a0cbb Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcwchen jcwchen jcwchen approved these changes

@xadupre xadupre xadupre approved these changes

Assignees
No one assigned
Labels
topic: documentation Issues related to ONNX documentation
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DynamicQuantizeLinear - Documentation example and reference mismatch
3 participants
@Swopper050 @jcwchen @xadupre