Updated DynamicQuantizeLinear docs to be consistent with reference implementation #5601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Swopper050 <bram@witoos.nl>
jcwchen
reviewed
Sep 19, 2023
|
Seems like you forked an old version of onnx and so the CI for "auto update doc" is not working.. Please follow the steps to update Operators.md accordingly. Thanks! |
|
Somehow I forked a different onnx repository. I've created a new pull request at #5603 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
…e implementation (#5603) Hi! Something went wrong with my other pull request (#5601), so I forked the right version and tried again: ### Description I changed the operator definition for DynamicQuantizeLinear to be consistent with the reference implementation as described in #5597 ### Motivation and Context #5597 --------- Signed-off-by: Swopper050 <bram@witoos.nl> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Swopper050 <bram@witoos.nl> Co-authored-by: jcwchen <jcwchen@users.noreply.github.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is my first pull request in ONNX. Open to any feedback!
Description
I changed the operator definition for DynamicQuantizeLinear to be consistent with the reference implementation as described in #5597
Motivation and Context
#5597
Do I also need to regenerate the Operators.md? Or is this done on new releases?