Reject absolute path when saving external data #5566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xadupre
reviewed
Sep 4, 2023
Respect the proto def. Close onnx#5552. Signed-off-by: Zhenhua Wang <zhenhuaw@nvidia.com>
2a542b2 to
1b1f9ee
Compare
jcwchen
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Thank you for the PR! Only allowing relative path makes sense to me. Might be worthy to mention this limitation in the document for external data as well: https://github.com/onnx/onnx/blob/main/docs/PythonAPIOverview.md#loading-an-onnx-model-with-external-data.
Another document actually has mentioned the location should be relative path already: https://github.com/onnx/onnx/blob/main/docs/ExternalData.md#external_data-field.
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
Respect the proto def. Close onnx#5552. Signed-off-by: Zhenhua Wang <zhenhuaw@nvidia.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect the proto def. Close #5552.