Add BOOL to ReduceMax/Min #5539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
eced098 to
33aae93
Compare
justinchuby
commented
Aug 31, 2023
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
jcwchen
reviewed
Aug 31, 2023
Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
gramalingam
reviewed
Aug 31, 2023
gramalingam
reviewed
Aug 31, 2023
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
xadupre
approved these changes
Sep 1, 2023
gramalingam
approved these changes
Sep 1, 2023
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
### Description Add BOOL as a support dtype to ReduceMin and ReduceMax - [x] Update the opset in `defs.cc` - [x] Move the old definition of `old.cc` - [x] Add the operator to `onnx/defs/operator_sets.h` - [x] Create node tests - [x] Create reference implementation: Nothing needs to be done it seems - [x] Update version converter - [x] ~Create shape inference and checker tests~ - [x] Build docs ### Motivation and Context Fixes onnx#5452 --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add BOOL as a support dtype to ReduceMin and ReduceMax
defs.ccold.cconnx/defs/operator_sets.hCreate shape inference and checker testsMotivation and Context
Fixes #5452