Create the onnxtxt serialization format #5524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
justinchuby
commented
Aug 24, 2023
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
There was a problem hiding this comment.
lintrunner found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
commented
Aug 24, 2023
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
d62216b to
44aa8b5
Compare
jcwchen
reviewed
Aug 25, 2023
justinchuby
commented
Aug 25, 2023
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
jcwchen
approved these changes
Aug 25, 2023
|
I am going to merge this first and work on a page to document limitations |
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
Add support for serializing to and deserializing from the ONNX textual representation, and register it under the `onnxtxt` file extension and format. Users can now save a model to the textual representation with `onnx.save_model(model, "model.onnxtxt")` Note that the textual format has known limitations, including (1) it doesn’t serialize tensor protos or initializers and (2) bugs like onnx#5102. We will call this out in a documentation in a separate PR. --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
Add support for serializing to and deserializing from the ONNX textual representation, and register it under the `onnxtxt` file extension and format. Users can now save a model to the textual representation with `onnx.save_model(model, "model.onnxtxt")` Note that the textual format has known limitations, including (1) it doesn’t serialize tensor protos or initializers and (2) bugs like onnx#5102. We will call this out in a documentation in a separate PR. --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
Add support for serializing to and deserializing from the ONNX textual representation, and register it under the `onnxtxt` file extension and format. Users can now save a model to the textual representation with `onnx.save_model(model, "model.onnxtxt")` Note that the textual format has known limitations, including (1) it doesn’t serialize tensor protos or initializers and (2) bugs like onnx#5102. We will call this out in a documentation in a separate PR. --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for serializing to and deserializing from the ONNX textual representation, and register it under the
onnxtxtfile extension and format.Users can now save a model to the textual representation with
onnx.save_model(model, "model.onnxtxt")Note that the textual format has known limitations, including (1) it doesn’t serialize tensor protos or initializers and (2) bugs like #5102. We will call this out in a documentation in a separate PR.