Skip to content

Add double support to tensor attribute LabelEncoder #5521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 23, 2023
Merged

Add double support to tensor attribute LabelEncoder #5521

merged 3 commits into from
Aug 23, 2023

Conversation

adityagoel4512
Copy link
Contributor

Description

In #5453, we should have added support for double inputs. This PR adds double input tensor support.

@adityagoel4512
Initial implementation
eb21a21 
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
@adityagoel4512
Clean history
9940506 
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
@adityagoel4512 adityagoel4512 force-pushed the label_encoder_with_tensor_attributes branch from d0504b7 to 9940506 Compare August 23, 2023 11:43
@adityagoel4512
Merge branch 'main' into label_encoder_with_tensor_attributes
e93b461 
Signed-off-by: Aditya Goel <48102515+adityagoel4512@users.noreply.github.com>
@adityagoel4512 adityagoel4512 marked this pull request as ready for review August 23, 2023 11:46
@adityagoel4512 adityagoel4512 requested a review from a team as a code owner August 23, 2023 11:46
@jcwchen jcwchen added module: schema Issues related to operator schemas topic: operator Issues related to ONNX operators labels Aug 23, 2023
@justinchuby
Copy link
Member

@gramalingam

@justinchuby justinchuby enabled auto-merge August 23, 2023 19:44
@justinchuby justinchuby added this pull request to the merge queue Aug 23, 2023
Merged via the queue into onnx:main with commit 45d54c1 Aug 23, 2023
corwinjoy pushed a commit to corwinjoy/onnx that referenced this pull request Sep 5, 2023
@adityagoel4512
Add double support to tensor attribute LabelEncoder (onnx#5521)
ebc8027 
### Description
In onnx#5453, we should have added support
for double inputs. This PR adds double input tensor support.

---------

Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Signed-off-by: Aditya Goel <48102515+adityagoel4512@users.noreply.github.com>
Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy pushed a commit to corwinjoy/onnx that referenced this pull request Sep 5, 2023
@adityagoel4512
Add double support to tensor attribute LabelEncoder (onnx#5521)
214078f 
### Description
In onnx#5453, we should have added support
for double inputs. This PR adds double input tensor support.

---------

Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Signed-off-by: Aditya Goel <48102515+adityagoel4512@users.noreply.github.com>
Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy pushed a commit to corwinjoy/onnx that referenced this pull request Sep 5, 2023
@adityagoel4512
Add double support to tensor attribute LabelEncoder (onnx#5521)
23d9e42 
### Description
In onnx#5453, we should have added support
for double inputs. This PR adds double input tensor support.

---------

Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Signed-off-by: Aditya Goel <48102515+adityagoel4512@users.noreply.github.com>
Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramalingam gramalingam gramalingam approved these changes

@jcwchen jcwchen jcwchen approved these changes

Assignees
No one assigned
Labels
module: schema Issues related to operator schemas topic: operator Issues related to ONNX operators
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adityagoel4512 @justinchuby @gramalingam @jcwchen