Create DFT-20 #5514

justinchuby · 2023-08-21T18:58:49Z

Description

Promote the axis attribute to input in DFT-20 and default it to -2. axis is now input number 2, after dft_length.
Update documentation for the spec to be clearer
Move SoftmaxFamilyDocGenerator to defs and move utilities into the ONNX_NAMESPACE::defs::math::utils namespace
Simplify reference evaluator logic

Checklist

Update the opset in defs.cc
Move the old definition of old.cc
Add the operator to onnx/defs/operator_sets.h or onnx/defs/operator_sets_ml.h
Create node tests
Disable the tests in test_backend_onnxruntime.py
Create reference implementation
Update version converter (Separate PR)
Create shape inference and checker tests
Build docs or use the auto update doc label on the GitHub pull request to update the generated documentation

Motivation and Context

Fixes #5447 Fixes #5493

Reference

https://github.com/openxla/xla/blob/main/docs/operation_semantics.md#fft

Signed-off-by: Justin Chu <justinchu@microsoft.com>

onnx/defs/math/defs.cc

onnx/reference/ops/op_dft.py

Signed-off-by: Justin Chu <justinchu@microsoft.com>

onnx/reference/ops/op_dft.py

Signed-off-by: Justin Chu <justinchu@microsoft.com>

onnx/defs/math/defs.cc

Signed-off-by: Justin Chu <justinchu@microsoft.com>

onnx/version_converter/adapters/axis_attribute_to_input.h

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Signed-off-by: Justin Chu <justinchu@microsoft.com>

onnx/defs/math/defs.cc

onnx/test/shape_inference_test.py

Signed-off-by: Justin Chu <justinchu@microsoft.com>

onnx/defs/math/defs.cc

Signed-off-by: Justin Chu <justinchu@microsoft.com>

onnx/test/shape_inference_test.py

+            ]
+            value_infos = [make_tensor_value_info("dft_length", TensorProto.INT64, ())]
+        else:
+            assert version >= 20


gramalingam · 2023-09-22T22:54:46Z

onnx/defs/math/defs.cc

-              int dim_size = result_shape_proto.dim_size();
-              result_shape_proto.mutable_dim(dim_size - 1)->set_dim_value(2);
-              updateOutputShape(ctx, output_index, result_shape_proto);
+              ONNX_ASSERTM(


Was this meant for debugging? Seems a very local, straightforward, assertion, wonder if we need it. (nit)

It was meant to guard a segfault because new_shape_proto.mutable_dim() will not fail gracefully (when there is a bug)

justinchuby · 2023-09-22T23:18:36Z

Merging for now! Will follow up as needed

jcwchen

The release CIs for testing older NumPy version (1.16.6) seems failed after this PR. @justinchuby could you please take a closer look? I suspect this is related to DFT's reference implementation. The tests with the latest NumPy is fine, but the tests for NumPy==1.16.6 failed: https://github.com/onnx/onnx/actions/runs/6280136187/job/17056899644.

Implement version converter to complete DFT-20. Requires #5514 Reference: #5514 (comment) --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Co-authored-by: Ganesan Ramalingam <grama@microsoft.com>

justinchuby requested a review from a team as a code owner August 21, 2023 18:58

justinchuby marked this pull request as draft August 21, 2023 18:59

justinchuby force-pushed the justinchu/dft branch from 840a8c0 to a4bf5ae Compare August 21, 2023 22:09

Create DFT-20

a9db6ad

Signed-off-by: Justin Chu <justinchu@microsoft.com>

justinchuby force-pushed the justinchu/dft branch from a4bf5ae to a9db6ad Compare August 21, 2023 22:20

justinchuby added 2 commits August 21, 2023 22:23

typo

b1ac96a

Signed-off-by: Justin Chu <justinchu@microsoft.com>

Reference

632e9e1

Signed-off-by: Justin Chu <justinchu@microsoft.com>

justinchuby commented Aug 21, 2023

View reviewed changes

onnx/defs/math/defs.cc Outdated Show resolved Hide resolved

justinchuby commented Aug 21, 2023

View reviewed changes

onnx/reference/ops/op_dft.py Outdated Show resolved Hide resolved

justinchuby requested review from gramalingam and xadupre August 21, 2023 23:18

justinchuby added 3 commits August 21, 2023 23:43

utils

b712886

Signed-off-by: Justin Chu <justinchu@microsoft.com>

Refactor ref implementation

69d0f4e

Signed-off-by: Justin Chu <justinchu@microsoft.com>

Static functions?

dba3f96

Signed-off-by: Justin Chu <justinchu@microsoft.com>

github-advanced-security bot found potential problems Aug 22, 2023

View reviewed changes

onnx/reference/ops/op_dft.py Fixed Show fixed Hide fixed

onnx/reference/ops/op_dft.py Fixed Show fixed Hide fixed

onnx/reference/ops/op_dft.py Fixed Show fixed Hide fixed

onnx/reference/ops/op_dft.py Fixed Show fixed Hide fixed

namespace

b9895a0

Signed-off-by: Justin Chu <justinchu@microsoft.com>

jcwchen modified the milestone: 1.15 Aug 24, 2023

xadupre reviewed Aug 28, 2023

View reviewed changes

onnx/defs/math/defs.cc Outdated Show resolved Hide resolved

justinchuby added this to the 1.15 milestone Aug 31, 2023

justinchuby added the topic: operator Issues related to ONNX operators label Sep 12, 2023

justinchuby added 6 commits September 12, 2023 23:15

Merge branch 'main' into justinchu/dft

fcbd610

Update defs

43d4316

Signed-off-by: Justin Chu <justinchu@microsoft.com>

Fix function call

6f37327

Signed-off-by: Justin Chu <justinchu@microsoft.com>

register

f809264

Signed-off-by: Justin Chu <justinchu@microsoft.com>

Implement version converter

88fb79f

Signed-off-by: Justin Chu <justinchu@microsoft.com>

spec

5d702f8

Signed-off-by: Justin Chu <justinchu@microsoft.com>

justinchuby added the auto update doc Generate md/proto files automatically using the CI pipeline label Sep 13, 2023

Size check

5eea907

Signed-off-by: Justin Chu <justinchu@microsoft.com>

github-advanced-security bot found potential problems Sep 13, 2023

View reviewed changes

onnx/version_converter/adapters/axis_attribute_to_input.h Fixed Show fixed Hide fixed

justinchuby and others added 3 commits September 21, 2023 23:22

CI:apply auto updated documentation/backend test data

4a08cdd

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Fix annotations

145f10d

Signed-off-by: Justin Chu <justinchu@microsoft.com>

Merge branch 'main' into justinchu/dft

7afbfd3

justinchuby added module: shape inference Issues related to shape inference module: reference implementation labels Sep 21, 2023

justinchuby enabled auto-merge September 22, 2023 02:10

gramalingam reviewed Sep 22, 2023

View reviewed changes

onnx/defs/math/defs.cc Outdated Show resolved Hide resolved

gramalingam reviewed Sep 22, 2023

View reviewed changes

onnx/test/shape_inference_test.py Show resolved Hide resolved

justinchuby disabled auto-merge September 22, 2023 16:05

Handle unknown axis and added tests

6e5b0da

Signed-off-by: Justin Chu <justinchu@microsoft.com>

justinchuby mentioned this pull request Sep 22, 2023

Add backward conversions from 18->17 for reduce ops #5606

Merged

justinchuby added 2 commits September 22, 2023 11:12

Segfault

f981370

Signed-off-by: Justin Chu <justinchu@microsoft.com>

Snapshot

402e04d

Signed-off-by: Justin Chu <justinchu@microsoft.com>

gramalingam reviewed Sep 22, 2023

View reviewed changes

onnx/defs/math/defs.cc Outdated Show resolved Hide resolved

gramalingam reviewed Sep 22, 2023

View reviewed changes

onnx/defs/math/defs.cc Show resolved Hide resolved

Fix segfault

247844b

Signed-off-by: Justin Chu <justinchu@microsoft.com>

github-advanced-security bot found potential problems Sep 22, 2023

View reviewed changes

onnx/test/shape_inference_test.py

]

value_infos = [make_tensor_value_info("dft_length", TensorProto.INT64, ())]

else:

assert version >= 20

Check warning

Code scanning / CodeQL

Redundant comparison

Test is always true, because of [this condition](1).

justinchuby mentioned this pull request Sep 22, 2023

Create reduce min/max test data #5614

Merged

gramalingam reviewed Sep 22, 2023

View reviewed changes

gramalingam approved these changes Sep 22, 2023

View reviewed changes

justinchuby enabled auto-merge September 22, 2023 23:05

justinchuby added this pull request to the merge queue Sep 22, 2023

Merged via the queue into onnx:main with commit 2026f6b Sep 22, 2023

justinchuby deleted the justinchu/dft branch September 22, 2023 23:43

jcwchen reviewed Sep 25, 2023

View reviewed changes

jcwchen mentioned this pull request Sep 25, 2023

update version number to 1.15.0rc1 #5620

Merged

liqunfu mentioned this pull request Sep 27, 2023

Add compute kernel for DFT(20) microsoft/onnxruntime#17723

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Create DFT-20 #5514

Create DFT-20 #5514

Uh oh!

justinchuby commented Aug 21, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

gramalingam Sep 22, 2023

Uh oh!

justinchuby Sep 22, 2023 •

edited

Loading

Uh oh!

justinchuby commented Sep 22, 2023

Uh oh!

jcwchen left a comment

Uh oh!

Uh oh!

Create DFT-20 #5514

Create DFT-20 #5514

Uh oh!

Conversation

justinchuby commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Motivation and Context

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

gramalingam Sep 22, 2023

Choose a reason for hiding this comment

Uh oh!

justinchuby Sep 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinchuby commented Sep 22, 2023

Uh oh!

jcwchen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

justinchuby commented Aug 21, 2023 •

edited

Loading

justinchuby Sep 22, 2023 •

edited

Loading