[Doc] Update README.md regarding Protobuf update and fix typo in Slice-13 spec #5435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
justinchuby
approved these changes
Jul 20, 2023
xadupre
approved these changes
Jul 21, 2023
adityagoel4512
pushed a commit
to adityagoel4512/onnx
that referenced
this pull request
Jul 28, 2023
…e-13 spec (onnx#5435) ### Description <!-- - Describe your changes. --> - README.md - Mention Protobuf will be internally installed if there is not preinstalled Protobuf. - Upgrade recommended Protobuf version from 3.20.2 to 4.21.12, which is the same version as what release pipelines are using. - Potential Slice-13 typo: `start[i]` -> `starts[i]`, `end[i]` -> `ends[i]`, `step[i]` -> `steps[i]`. Not sure whether it is intended, but they seem misleading -- Users might mistake the correct attribute name `steps` for `step`. Thanks @satyajandhyala for catching this. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> - With onnx#5196, now ONNX is able to install Protobuf internally if there is not preinstalled Protobuf. README.md should reflect that enhancement. Besides, currently release Pipelines are using Protobuf 21.12 (4.21.12) and so let's upgrade the recommended Protobuf version as 21.12 accordingly. - Possible typo in Slice-13 doc. --------- Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512
pushed a commit
to adityagoel4512/onnx
that referenced
this pull request
Jul 28, 2023
…e-13 spec (onnx#5435) ### Description <!-- - Describe your changes. --> - README.md - Mention Protobuf will be internally installed if there is not preinstalled Protobuf. - Upgrade recommended Protobuf version from 3.20.2 to 4.21.12, which is the same version as what release pipelines are using. - Potential Slice-13 typo: `start[i]` -> `starts[i]`, `end[i]` -> `ends[i]`, `step[i]` -> `steps[i]`. Not sure whether it is intended, but they seem misleading -- Users might mistake the correct attribute name `steps` for `step`. Thanks @satyajandhyala for catching this. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> - With onnx#5196, now ONNX is able to install Protobuf internally if there is not preinstalled Protobuf. README.md should reflect that enhancement. Besides, currently release Pipelines are using Protobuf 21.12 (4.21.12) and so let's upgrade the recommended Protobuf version as 21.12 accordingly. - Possible typo in Slice-13 doc. --------- Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512
pushed a commit
to adityagoel4512/onnx
that referenced
this pull request
Jul 28, 2023
…e-13 spec (onnx#5435) ### Description <!-- - Describe your changes. --> - README.md - Mention Protobuf will be internally installed if there is not preinstalled Protobuf. - Upgrade recommended Protobuf version from 3.20.2 to 4.21.12, which is the same version as what release pipelines are using. - Potential Slice-13 typo: `start[i]` -> `starts[i]`, `end[i]` -> `ends[i]`, `step[i]` -> `steps[i]`. Not sure whether it is intended, but they seem misleading -- Users might mistake the correct attribute name `steps` for `step`. Thanks @satyajandhyala for catching this. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> - With onnx#5196, now ONNX is able to install Protobuf internally if there is not preinstalled Protobuf. README.md should reflect that enhancement. Besides, currently release Pipelines are using Protobuf 21.12 (4.21.12) and so let's upgrade the recommended Protobuf version as 21.12 accordingly. - Possible typo in Slice-13 doc. --------- Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
start[i]->starts[i],end[i]->ends[i],step[i]->steps[i]. Not sure whether it is intended, but they seem misleading -- Users might mistake the correct attribute namestepsforstep. Thanks @satyajandhyala for catching this.Motivation and Context