Skip to content

Conversation

xadupre
Copy link
Contributor

@xadupre xadupre commented Jul 19, 2023

Description

This action checks that urls in the code or in the documentation are valid.

Motivation and Context

It avoids having broken urls.

xadupre added 2 commits July 19, 2023 19:15
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@xadupre xadupre requested a review from a team as a code owner July 19, 2023 17:38
@jcwchen jcwchen added the module: CI pipelines Issues related to the CI pipeline label Jul 19, 2023
@justinchuby
Copy link
Member

I didn't see it running in this pr. Do we need to configure triggers?

xadupre added 3 commits July 24, 2023 18:07
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update -- now this added CI was triggered in this PR, but according to the log, the CI did not fail when it found some invalid URLs.

xadupre added 3 commits July 25, 2023 11:55
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@xadupre xadupre requested a review from a team as a code owner July 25, 2023 09:58
xadupre and others added 7 commits July 25, 2023 12:14
Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Xavier Dupré <xadupre@users.noreply.github.com>
Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Xavier Dupré <xadupre@users.noreply.github.com>
Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Xavier Dupré <xadupre@users.noreply.github.com>
Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Xavier Dupré <xadupre@users.noreply.github.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@xadupre xadupre enabled auto-merge July 27, 2023 07:22
@justinchuby justinchuby requested a review from gramalingam August 3, 2023 13:11
@justinchuby
Copy link
Member

@gramalingam for approval

@justinchuby
Copy link
Member

@onnx/sig-operators-approvers for approval

@xadupre xadupre added this pull request to the merge queue Aug 11, 2023
@justinchuby justinchuby removed this pull request from the merge queue due to a manual request Aug 11, 2023
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby enabled auto-merge August 11, 2023 19:22
@justinchuby justinchuby added this pull request to the merge queue Aug 11, 2023
Merged via the queue into onnx:main with commit ec38b7c Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: CI pipelines Issues related to the CI pipeline
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants