Add Split-18: new num_outputs attribute #4389
Conversation
|
Previously discussed in #4358 |
onnx/backend/test/case/node/split.py
Outdated
| @@ -17,7 +17,8 @@ def export_1d() -> None: | |||
| 'Split', | |||
| inputs=['input'], | |||
| outputs=['output_1', 'output_2', 'output_3'], | |||
| axis=0 | |||
| axis=0, | |||
| num_outputs=3 | |||
There was a problem hiding this comment.
I think we should perhaps have test-cases for both the earlier version and newer version? @jcwchen ?
There was a problem hiding this comment.
After this PR: #3855, going forward all of node test cases for the same operator will be updated to the latest opset version if there is an opset bump. If people would like to keep some old test cases for old opset versions, they need to specify the opset_version while creating node test cases. Take Loop op as an example, see this line.
There was a problem hiding this comment.
I believe that we will need to copy the old test-case, but add the opset version to be the old one (and the new one can be as in the current PR)?
There was a problem hiding this comment.
Correct. In that case we can keep the same test cases for both newer and older opset versions.
There was a problem hiding this comment.
I applied the changes you suggested. Opset13 tests were reverted, new (opset18) tests stayed the same.
|
For unknown reason (might be a GitHub server issue), this PR hasn't been merged into the main branch even after 1 hrs... Let's see whether it will be merged toady. |
|
As per @p-wysocki , it is unclear why this (empty) merge even happened. He says he did nothing to trigger it. And it seems to be an empty merge with no commits. What's happening? Seems mysterious to me. |
|
I was 1 commit ahead of We had this happen in OpenVINO too, where an external contributor seemingly merged his changes, but they were not on master and the PR showed 0 changed files. |
Signed-off-by: p-wysocki przemyslaw.wysocki@intel.com
Description
num_outputsdetermining the number of equally sized output tensors.Motivation and Context