Skip to content

Allow for both scales and sizes to be provided when one of them is an empty constant #4388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 6, 2022
Merged

Allow for both scales and sizes to be provided when one of them is an empty constant #4388

merged 4 commits into from
Aug 6, 2022

Conversation

jantonguirao
Copy link
Contributor

Signed-off-by: Joaquin Anton janton@nvidia.com

Description

  • It changes the shape inference logic of Resize so that it allows for both scales and sizes to be explicitly provided when at least one of them is an empty constant. In such cases we assume it's not provided

Motivation and Context

@jantonguirao
Allow for both scales and sizes to be provided when one of them is an…
3a42aee 
… empty constant

Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao jantonguirao requested review from a team as code owners July 27, 2022 13:59
@jantonguirao jantonguirao mentioned this pull request Jul 27, 2022
Closed
@jcwchen jcwchen added the test ONNX Model Zoo [Caution] It will test this PR with ONNX Model Zoo label Jul 27, 2022
@p-wysocki
Copy link
Contributor

Good change, LTGM.

jcwchen
jcwchen approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@jcwchen jcwchen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(*Update) LGTM. Thank you for the quick update! I can verify this update can solve previous failures on ONNX Model Zoo models.

@jcwchen jcwchen added module: shape inference Issues related to shape inference and removed test ONNX Model Zoo [Caution] It will test this PR with ONNX Model Zoo labels Jul 27, 2022
@daquexian daquexian enabled auto-merge (squash) August 5, 2022 16:12
@daquexian daquexian merged commit eb634ad into onnx:main Aug 6, 2022
@liqunfu liqunfu mentioned this pull request Aug 17, 2022
Merged
@jcwchen jcwchen mentioned this pull request Oct 12, 2022
Merged
broune pushed a commit to broune/onnx that referenced this pull request May 6, 2023
@jantonguirao @jcwchen @daquexian
Allow for both scales and sizes to be provided when one of them is an…
6bc6966 
… empty constant (onnx#4388)

Signed-off-by: Joaquin Anton <janton@nvidia.com>

Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Co-authored-by: daquexian <daquexian566@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daquexian daquexian daquexian approved these changes

@jcwchen jcwchen jcwchen approved these changes

Assignees
No one assigned
Labels
module: shape inference Issues related to shape inference
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Resize check for sizes and scales breaks some existing models
4 participants
@jantonguirao @p-wysocki @daquexian @jcwchen