Use fully qualified pathname when loading DLL to prevent security vulnerability #4377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulnerability Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
…into jcw/fix-onnxifi-vlun
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
AlexandreEichenberger
approved these changes
Jul 26, 2022
|
Can an approved accept this PR as it is a potential vulnerability. Thanks |
|
cc @onnx/sig-archinfra-approvers PTAL. Thanks! |
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Thanks for catching this. |
liqunfu
approved these changes
Aug 3, 2022
gramalingam
approved these changes
Aug 4, 2022
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
…nerability (onnx#4377) * Use a fully qualified pathname when loading DLL to prevent security vulnerability Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use path instead of define Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * nit: style Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * LOAD_WITH_ALTERED_SEARCH_PATH Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To prevent security vulnerability, we should use fully qualified pathname when loading DLL.
Motivation and Context
Security vulnerability: The LoadLibrary*() family of functions are used to dynamically load a DLL into your
program. Most versions of the Windows operating system search the current directory first
when attempting to load files. If you do not specify a fully qualified pathname when loading
a Windows dynamic load library (DLL), the loader will attempt to locate the library in the
current directory. If there is a malicious library located in the current directory, it will be
loaded instead of the intended library.