-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Temporarily disable testing real models from AWS #4859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THanks for the fix! I agree to remove the failing tests for now. Shall we replace them later?
It's better to explain how future developers will run equivalent tests on their local machines in this PR. Can you add a document with real code to explain how to use ONNX hub for test a model with example data? I saw limited doc for loading a model but doesn't find instructions to really execute the model with example data. |
This is massif. Can we try this PR on ORT branch to make sure this fixes our pipelines? |
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
9cf0ffa
to
054f0c3
Compare
After discussion with Liqun, we decide to temporarily disable testing real models from AWS in onnx repo to faster unblock pipeline failures. Liqun will try to move them elsewhere like Azure. Then, we will add these tests back with updated URL instead of the current AWS URL.
Good point. IIUC, onnx repo only tests the model itself: https://github.com/onnx/onnx/blob/main/onnx/test/test_backend_test.py#L38-L42 since previously there is no runtime implementation here. So the corresponding tests will be (Take AlexNet as an example)
I will provide the full equivalent testing method if we eventually decide to remove them for good. |
ORT pipelines will be OK for now by manually disabling these real model tests (from onnx repo) there: microsoft/onnxruntime#14606. In the near future, after we have transferred these models to a new place, we will update the URL in ONNX repo, have a patch release commit with that update and then consume that ONNX commit in ORT to recover these tests. Ideally only URLs will be updated and all other relevant stuff in ONNX will be consistent. |
Instead of copying the models somewhere else, would it be possible to remove the initializers and replace them by a node |
Description
These models were moved to git-lfs in https://github.com/onnx/models. Currently all ONNX Model Zoo models will be tested weekly by the weekly CI pipleine: https://github.com/onnx/onnx/blob/main/.github/workflows/weekly_mac_ci.yml.
Removing testing real models from AWS should be fine.To faster unblock global pipeline faillure, temporarily disable testing real models from AWS. We will add them back in the near future.Motivation and Context
See #4857. The models from AWS are broken.