Skip to content

Fix input_1 data to has got same shape as in model #4684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 11, 2023
Merged

Fix input_1 data to has got same shape as in model #4684

merged 11 commits into from
May 11, 2023

Conversation

praasz
Copy link
Contributor

@praasz praasz commented Dec 1, 2022

Description

The test models in backend tests:

  • test_castlike_BFLOAT16_to_FLOAT
  • test_castlike_FLOAT_to_BFFLOAT16
    have changed between versions 1.11 and 1.12. The input 'Like' has got shape 3x4 instead 1 but data for this input is still shape of 1.

This change add consistency between model and data.

Motivation and Context

The OpenVINO project use this tests. After upgrade from 1.11 -> 1.12 these test start failing as there is no consistency between input data and inputs shapes.

@praasz praasz requested a review from a team as a code owner December 1, 2022 15:00
@praasz
Fix input_1 data to has got same shape as in model
f77f056 
Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
@praasz praasz force-pushed the bugfix/castlike-tests-model-like-data-shape-mistmatch branch from 0d6ccac to f77f056 Compare December 1, 2022 15:03
@daquexian
Copy link
Member

daquexian commented Jan 25, 2023 •
edited
Loading

Thanks for your contribution!

However, it seems that the shape of like should be exactly [1] instead of [3, 4]

onnx/onnx/backend/test/case/node/castlike.py

Line 123 in 791ab90

like = output.flatten()[0:1]

And I think the mismatch you encountered comes from that we specified a wrong type proto here:

onnx/onnx/backend/test/case/node/castlike.py

Line 135 in 791ab90

input_type_protos=[input_type_proto, output_type_proto],

output_type_proto (whose shape is [3,4]) is incorrectly used as the type proto of like (whose shape is [1])

@praasz praasz force-pushed the bugfix/castlike-tests-model-like-data-shape-mistmatch branch from d0e9801 to bc1812e Compare April 25, 2023 13:35
praasz added 3 commits April 25, 2023 15:44
@praasz
Update test coverage
02c1e68 
Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
@praasz
Update operators documentation
b15cffd 
Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
@praasz
Merge branch 'main' into bugfix/castlike-tests-model-like-data-shape-…
62f4fc0 
…mistmatch
@praasz
Copy link
Contributor Author

praasz commented Apr 26, 2023

Thanks for your contribution!

However, it seems that the shape of like should be exactly [1] instead of [3, 4]

onnx/onnx/backend/test/case/node/castlike.py

Line 123 in 791ab90

like = output.flatten()[0:1]

And I think the mismatch you encountered comes from that we specified a wrong type proto here:

onnx/onnx/backend/test/case/node/castlike.py

Line 135 in 791ab90

input_type_protos=[input_type_proto, output_type_proto],

output_type_proto (whose shape is [3,4]) is incorrectly used as the type proto of like (whose shape is [1])

You've got right about proto. I've created like proto which use correct shape and generated test model will have correct inputs aligned with test data.

@p-wysocki
Copy link
Contributor

@gramalingam @jcwchen could you please approve necessary CI workflows?

@jcwchen jcwchen added the run release CIs Use this label to trigger release tests in CI label May 10, 2023
@jcwchen jcwchen enabled auto-merge (squash) May 11, 2023 04:30
@jcwchen jcwchen merged commit 745b9be into onnx:main May 11, 2023
@praasz praasz deleted the bugfix/castlike-tests-model-like-data-shape-mistmatch branch May 12, 2023 05:47
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this pull request Jul 28, 2023
@praasz @gramalingam
@jcwchen @adityagoel4512
Fix input_1 data to has got same shape as in model (onnx#4684)
1a49593 
Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
Co-authored-by: G. Ramalingam <grama@microsoft.com>
Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramalingam gramalingam gramalingam approved these changes

+1 more reviewer

@p-wysocki p-wysocki p-wysocki approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
run release CIs Use this label to trigger release tests in CI topic: test
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@praasz @daquexian @p-wysocki @gramalingam @jcwchen