Fix backend test for ReferenceEvaluator with numpy 1.16.6 #4658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xadupre <xadupre@microsoft.com>
|
Thank you for fixing this. Please allow me to reopen this PR to trigger release CIs. |
jcwchen
reviewed
Nov 15, 2022
There was a problem hiding this comment.
Tests with NumPy 1.16.6 now looks good, but tests in Windows x86 are still failing. (See https://github.com/onnx/onnx/actions/runs/3471448294/jobs/5800951391)
|
Sorry for that, building onnx on Windows is always difficult. I'm working on that. |
Signed-off-by: xadupre <xadupre@microsoft.com>
Signed-off-by: xadupre <xadupre@microsoft.com>
Signed-off-by: xadupre <xadupre@microsoft.com>
|
The issues come from the use of int64 for integers. A couple of functions in x64 distribution don't support that. |
|
I added some code to catch the exceptions raised by numpy on python x86 to convert int64 into python int. It was working locally for me. I added an explicit comment that it was needed for x86 in the few places it was needed. |
jcwchen
approved these changes
Nov 16, 2022
justinchuby
pushed a commit
to justinchuby/onnx
that referenced
this pull request
Jan 27, 2023
* Fix ReferenceEvaluator for numpy 1.16.6 Signed-off-by: xadupre <xadupre@microsoft.com> * fix bug in _unsqueeze Signed-off-by: xadupre <xadupre@microsoft.com> * disabling failing tests on windows x86 and old numpy Signed-off-by: xadupre <xadupre@microsoft.com> * fix unit test for x86 Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com>
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
* Fix ReferenceEvaluator for numpy 1.16.6 Signed-off-by: xadupre <xadupre@microsoft.com> * fix bug in _unsqueeze Signed-off-by: xadupre <xadupre@microsoft.com> * disabling failing tests on windows x86 and old numpy Signed-off-by: xadupre <xadupre@microsoft.com> * fix unit test for x86 Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #4657.