Skip to content

Upgrade pybind11 to 2.9.2 to improve Python 3.11 support #4635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2022
Merged

Upgrade pybind11 to 2.9.2 to improve Python 3.11 support #4635

merged 2 commits into from
Nov 7, 2022

Conversation

jcwchen
Copy link
Member

@jcwchen jcwchen commented Nov 4, 2022

Description

Upgrade pybind11 to 2.9.2 to improve Python 3.11 support.

Motivation and Context

See #4490 (comment). Current pybind11 2.9.1 does not work well with fresh Python 3.11.

@jcwchen
Upgrade pybind11 to 2.9.2 to improve Python 3.11 support
1c5985b 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen jcwchen added run release CIs Use this label to trigger release tests in CI dependencies Pull requests that update a dependency file labels Nov 4, 2022
@jcwchen jcwchen requested a review from a team as a code owner November 4, 2022 22:15
@jcwchen jcwchen added this to the 1.13 milestone Nov 4, 2022
@jcwchen jcwchen mentioned this pull request Nov 4, 2022
Closed
@snnn
Copy link
Contributor

snnn commented Nov 5, 2022

LGTM.

@jcwchen jcwchen enabled auto-merge (squash) November 7, 2022 05:39
@jcwchen jcwchen merged commit d2f6cdf into onnx:main Nov 7, 2022
@jcwchen jcwchen deleted the jcw/pybind/2.9.2 branch November 7, 2022 13:41
@yan12125 yan12125 mentioned this pull request Nov 9, 2022
Merged
justinchuby pushed a commit to justinchuby/onnx that referenced this pull request Jan 27, 2023
@jcwchen @gramalingam @justinchuby
Upgrade pybind11 to 2.9.2 to improve Python 3.11 support (onnx#4635)
929a1a3 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Co-authored-by: G. Ramalingam <grama@microsoft.com>
broune pushed a commit to broune/onnx that referenced this pull request May 6, 2023
@jcwchen @gramalingam
Upgrade pybind11 to 2.9.2 to improve Python 3.11 support (onnx#4635)
83bacc4 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Co-authored-by: G. Ramalingam <grama@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramalingam gramalingam gramalingam approved these changes

+1 more reviewer

@snnn snnn snnn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file run release CIs Use this label to trigger release tests in CI
Projects
PR Tracker
Status: Done
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jcwchen @snnn @gramalingam