Remove unnecessary import #4484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xadupre <xadupre@microsoft.com>
|
The overlap seems small. It should be ok either way. |
|
@jcwchen the PR is ready to reviewed. black should prevent any merging issue. |
jcwchen
approved these changes
Sep 2, 2022
gramalingam
approved these changes
Sep 7, 2022
gramalingam
added a commit
that referenced
this pull request
Sep 23, 2022
* Remove unnecessary import (#4484) * remove unnecessary import Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * black Signed-off-by: xadupre <xadupre@microsoft.com> * black Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * restore old import Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> * fix mypy issues Signed-off-by: sdpython <xavier.dupre@gmail.com> Signed-off-by: xadupre <xadupre@microsoft.com> * fix mypy issues Signed-off-by: sdpython <xavier.dupre@gmail.com> Signed-off-by: xadupre <xadupre@microsoft.com> * update mypy Signed-off-by: sdpython <xavier.dupre@gmail.com> Signed-off-by: xadupre <xadupre@microsoft.com> * primary ops to function milestone 1 (#4458) * primary ops to function milestone 1 Signed-off-by: Liqun Fu <liqfu@microsoft.com> * float type Signed-off-by: Liqun Fu <liqfu@microsoft.com> * formatting Signed-off-by: Liqun Fu <liqfu@microsoft.com> * pass backend test Signed-off-by: Liqun Fu <liqfu@microsoft.com> * formatting Signed-off-by: Liqun Fu <liqfu@microsoft.com> * commit Signed-off-by: Liqun Fu <liqfu@microsoft.com> * format Signed-off-by: Liqun Fu <liqfu@microsoft.com> * format Signed-off-by: Liqun Fu <liqfu@microsoft.com> * layernorm Signed-off-by: Liqun Fu <liqfu@microsoft.com> * pass runtime check Signed-off-by: Liqun Fu <liqfu@microsoft.com> * format Signed-off-by: Liqun Fu <liqfu@microsoft.com> * pure function Signed-off-by: Liqun Fu <liqfu@microsoft.com> * format Signed-off-by: Liqun Fu <liqfu@microsoft.com> * reviewer's comments, clean up some Signed-off-by: Liqun Fu <liqfu@microsoft.com> * keep op original version Signed-off-by: Liqun Fu <liqfu@microsoft.com> * fix gtest.function_verify_test Signed-off-by: Liqun Fu <liqfu@microsoft.com> * formatting Signed-off-by: Liqun Fu <liqfu@microsoft.com> * update according to reviewer's comment Signed-off-by: Liqun Fu <liqfu@microsoft.com> Signed-off-by: Liqun Fu <liqfu@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: sdpython <xavier.dupre@gmail.com> Signed-off-by: xadupre <xadupre@microsoft.com> * remove # type: ignore for imports Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: sdpython <xavier.dupre@gmail.com> Signed-off-by: xadupre <xadupre@microsoft.com> * Use filesystem to load filename to prevent encoding issues on Windows (#4470) * apply filesystem from C+17 to handle encoding on Windows Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add comment in CMakeLists Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * precise msg if missing support Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * void normalize_sep for two types Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove typo const Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove template functions to header Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * apply clang-format Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use _wstat Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use define function to refactor code Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add required C++ version in readme Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * void char* for std::string in test Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix clang-format Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * move wchar_t and wstring only for Windows Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * refactor template Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * typo Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use char tempalte in template Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add comments Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add tests for wstring Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * typo Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * nit comments Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use existing functions from std::filesystem::path Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * honor != Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * constexpr const char Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * checker disallow absolute path in external tensors; remove related tests Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix format Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add more checker tests Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * black Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * improve comments Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: xadupre <xadupre@microsoft.com> * remove unnecessary ignore-missing-type Signed-off-by: sdpython <xavier.dupre@gmail.com> Signed-off-by: xadupre <xadupre@microsoft.com> * remove two type ignore Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * type Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: sdpython <xavier.dupre@gmail.com> Signed-off-by: Liqun Fu <liqfu@microsoft.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: sdpython <xavier.dupre@gmail.com> Co-authored-by: liqun Fu <liqfu@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
* remove unnecessary import Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * black Signed-off-by: xadupre <xadupre@microsoft.com> * black Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * restore old import Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com>
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
* Remove unnecessary import (onnx#4484) * remove unnecessary import Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * black Signed-off-by: xadupre <xadupre@microsoft.com> * black Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * restore old import Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> * fix mypy issues Signed-off-by: sdpython <xavier.dupre@gmail.com> Signed-off-by: xadupre <xadupre@microsoft.com> * fix mypy issues Signed-off-by: sdpython <xavier.dupre@gmail.com> Signed-off-by: xadupre <xadupre@microsoft.com> * update mypy Signed-off-by: sdpython <xavier.dupre@gmail.com> Signed-off-by: xadupre <xadupre@microsoft.com> * primary ops to function milestone 1 (onnx#4458) * primary ops to function milestone 1 Signed-off-by: Liqun Fu <liqfu@microsoft.com> * float type Signed-off-by: Liqun Fu <liqfu@microsoft.com> * formatting Signed-off-by: Liqun Fu <liqfu@microsoft.com> * pass backend test Signed-off-by: Liqun Fu <liqfu@microsoft.com> * formatting Signed-off-by: Liqun Fu <liqfu@microsoft.com> * commit Signed-off-by: Liqun Fu <liqfu@microsoft.com> * format Signed-off-by: Liqun Fu <liqfu@microsoft.com> * format Signed-off-by: Liqun Fu <liqfu@microsoft.com> * layernorm Signed-off-by: Liqun Fu <liqfu@microsoft.com> * pass runtime check Signed-off-by: Liqun Fu <liqfu@microsoft.com> * format Signed-off-by: Liqun Fu <liqfu@microsoft.com> * pure function Signed-off-by: Liqun Fu <liqfu@microsoft.com> * format Signed-off-by: Liqun Fu <liqfu@microsoft.com> * reviewer's comments, clean up some Signed-off-by: Liqun Fu <liqfu@microsoft.com> * keep op original version Signed-off-by: Liqun Fu <liqfu@microsoft.com> * fix gtest.function_verify_test Signed-off-by: Liqun Fu <liqfu@microsoft.com> * formatting Signed-off-by: Liqun Fu <liqfu@microsoft.com> * update according to reviewer's comment Signed-off-by: Liqun Fu <liqfu@microsoft.com> Signed-off-by: Liqun Fu <liqfu@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: sdpython <xavier.dupre@gmail.com> Signed-off-by: xadupre <xadupre@microsoft.com> * remove # type: ignore for imports Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: sdpython <xavier.dupre@gmail.com> Signed-off-by: xadupre <xadupre@microsoft.com> * Use filesystem to load filename to prevent encoding issues on Windows (onnx#4470) * apply filesystem from C+17 to handle encoding on Windows Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add comment in CMakeLists Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * precise msg if missing support Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * void normalize_sep for two types Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove typo const Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove template functions to header Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * apply clang-format Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use _wstat Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use define function to refactor code Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add required C++ version in readme Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * void char* for std::string in test Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix clang-format Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * move wchar_t and wstring only for Windows Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * refactor template Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * typo Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use char tempalte in template Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add comments Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add tests for wstring Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * typo Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * nit comments Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use existing functions from std::filesystem::path Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * honor != Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * constexpr const char Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * checker disallow absolute path in external tensors; remove related tests Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix format Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add more checker tests Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * black Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * improve comments Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: xadupre <xadupre@microsoft.com> * remove unnecessary ignore-missing-type Signed-off-by: sdpython <xavier.dupre@gmail.com> Signed-off-by: xadupre <xadupre@microsoft.com> * remove two type ignore Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * type Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: sdpython <xavier.dupre@gmail.com> Signed-off-by: Liqun Fu <liqfu@microsoft.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: sdpython <xavier.dupre@gmail.com> Co-authored-by: liqun Fu <liqfu@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xadupre xadupre@microsoft.com
Description
Remove unnecessary import, shorten a few very long line.
Motivation and Context
Better code.