Fix global LGTM Python/C++ warnings and fully enable it #4467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
|
This pull request fixes 1 alert when merging 037359b into 9b8c8d2 - view on LGTM.com fixed alerts:
|
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
|
This pull request fixes 1 alert when merging 6150b2d into 9b8c8d2 - view on LGTM.com fixed alerts:
|
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
|
This pull request fixes 1 alert when merging f19594a into 9b8c8d2 - view on LGTM.com fixed alerts:
|
gramalingam
approved these changes
Sep 14, 2022
|
This pull request fixes 1 alert when merging 6625dc0 into 5fbb7b5 - view on LGTM.com fixed alerts:
|
prasanthpul
pushed a commit
that referenced
this pull request
Oct 5, 2022
* Fix global LGTM warnings and fully enable it Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * - Exclude: py/import-and-import-from Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix the rest of warnings Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove unnecessary if Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Prasanth Pulavarthi <prasanth.pulavarthi@microsoft.com>
prasanthpul
pushed a commit
that referenced
this pull request
Jan 26, 2023
* Fix global LGTM warnings and fully enable it Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * - Exclude: py/import-and-import-from Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix the rest of warnings Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove unnecessary if Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Prasanth Pulavarthi <prasanth.pulavarthi@microsoft.com>
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
* Fix global LGTM warnings and fully enable it Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * - Exclude: py/import-and-import-from Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix the rest of warnings Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove unnecessary if Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: G. Ramalingam <grama@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix global LGTM Python/C++ warnings and fully enable this check in more files to enhance code quality. The warnings are:
Python:
C++:
Motivation and Context
LGTM excludes check for some files like test files (reference). You can see the full error report including excluded files by here. It would be great if we can fix these errors.: #3650 (comment)