Skip to content

New Resize check for sizes and scales breaks some existing models #4380

@jcwchen

Description

@jcwchen

Question

#4126 introduces new Resize check for sizes and scales that they cannot exist at the same time. Although I think it's a valid check, there are some existing models have sizes and scales simultaneously. Take yolov4 from ONNX Model Zoo as an example:
image
Its Resize has scales and sizes attributes at the same time, but its scales attribute is an empty tensor. Same thing happens in fcn-resnet as well. You can see the shape inference failures in this weekly CI with ONNX Model Zoo.

To make shape inference be compatible with existing models, is it possible that we kind of relax the check here? For example, further check whether scales or sizes is an empty tensor and do not throw an error if both of them exist but one of them is an empty tensor.

cc @onnx/sig-operators-approvers @jantonguirao

Further information

  • Relevant Area (e.g. model usage, backend, best practices, converters, shape_inference, version_converter, training, test, operators):
    Shape inference

  • Is this issue related to a specific model?
    Model name (e.g. mnist): yolov4, fcn-resnet
    Model opset (e.g. 7): 11, 12 (Resize)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions