-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Description
Problem
It's currently easy to merge a PR with missing or out-of-date backend test files.
CI can find issues if those files are present, particularly for functions, where the expanded graph can fail the checker or shape inference, exposing bugs in the body definition. (e.g. #2607 #2623)
Suggested resolution
It would be good to check in CI: generate backend test data & models and compare with what's checked into git.
Questions
It's worth noting that model files can have older IR and opset versions, but running tools/update_doc.sh
generates the same files with newer versions.
⇒ Question: presumably we want to keep these older versions the same -- should we change the python that generates them to explicitly set the versions? Atm it seems like a manual process of choosing which of the many changed files should actually be added to git.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status