Skip to content

Inconsistencies between MaxPool, AveragePool, and LpPool specs #2290

@JamesAllingham

Description

@JamesAllingham

The MaxPool op has a few attributes that neither AveragePool nor LpPool have (dilations and storage_order). It isn't clear to me why these attributes should be exclusive to MaxPool. Though, to be honest, I'm not really sure what storage_order is for at all :P.

Similarly, LpPool only has auto_pad, kernel_size, and strides in common with AveragePool and MaxPool. It is not clear to me why ceil_mode, and pads should not apply here too.

(On the other hand, I do see why the count_include_pad attribute of AveragePool and the p attribute of LpPool are specific to their ops.)

Can anyone provide some insight here?

Metadata

Metadata

Assignees

Labels

topic: operatorIssues related to ONNX operators

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions