Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

Conversation

borjarus
Copy link
Contributor

add new dev dependency to solve problem

I think latest commit of 'electron-devtools-installer' solve problem. Here is link to issue

add new dev dependency to solve problem
@codecov
Copy link

codecov bot commented Oct 26, 2018

Codecov Report

Merging #2650 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2650   +/-   ##
======================================
  Coverage    45.8%   45.8%           
======================================
  Files         361     361           
  Lines       14624   14624           
  Branches     1924    1924           
======================================
  Hits         6698    6698           
  Misses       7696    7696           
  Partials      230     230

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4dd8ad...4025889. Read the comment docs.

Copy link
Member

@akinsho akinsho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution 👍

@bryphe
Copy link
Member

bryphe commented Oct 30, 2018

👍 , thank you very much for the contribution @borjarus ! And thanks @akin909 for reviewing! Bringing it in now.

@bryphe bryphe merged commit 6ecc3f0 into onivim:master Oct 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants