This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Feature/remeasure window on commandline hide and show #2614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinsho
commented
Oct 4, 2018
| this._neovimInstance.callFunction("line", ["w0"]), | ||
| this._neovimInstance.callFunction("line", ["w$"]), | ||
| ]) | ||
| const [[topLine, bottomLine]] = await this._neovimInstance.request<[[number, number], any]>( |
There was a problem hiding this comment.
The logic is the same I just swapped this to use the atomic calls api so it works the same way as the call below (also I'm not sure if the atomic calls might be more performant vs. promise.all)
Codecov Report
@@ Coverage Diff @@
## master #2614 +/- ##
==========================================
- Coverage 45.3% 45.28% -0.02%
==========================================
Files 361 361
Lines 14571 14577 +6
Branches 1912 1912
==========================================
Hits 6601 6601
- Misses 7746 7752 +6
Partials 224 224
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #2612, the commandline can cause the window/viewport to be repositioned if
inccommandis enabled and so the window will shift to the next available match if this is off screen the window will reposition but this isn't passed on to the buffer layer render context so things like the indent lines remain incorrectly placed.This change causes the window to remeasure when this changes (the observable is essentially already throttled using
distinctUntilso don't think this should cause a performance issue as it will remeasure if the context changes i.e. if a reposition occurred.Unfortunately there isn't a more specific event to hook into if the window moves
This solves the issue of incorrectly placed buffer layer elements whilst searching using
/inside a file