Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

Fix completions with newer versions of vscode language server #2602

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Fix completions with newer versions of vscode language server #2602

merged 1 commit into from
Oct 2, 2018

Conversation

Prior99
Copy link
Contributor

@Prior99 Prior99 commented Oct 2, 2018

This fixes #2591

akinsho
akinsho approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@akinsho akinsho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Prior99 thanks for the contribution

@akinsho
Copy link
Member

akinsho commented Oct 2, 2018

The failure on appveyor isn't due to your change we encounter this issue from time to time due to running out of artefact space on appveyor

@bryphe
Copy link
Member

bryphe commented Oct 2, 2018 •
edited
Loading

Thanks for fixing this @Prior99 , much appreciated! 💯 Change looks great. (And thanks for the review, @akin909 !)

I'm following up with the build issue, and #2603 should address it - but I'll bring this in now since the build passed prior to uploading the artifacts.

@bryphe bryphe merged commit 87a2c93 into onivim:master Oct 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@akinsho akinsho akinsho approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when triggering autocomplete
3 participants
@Prior99 @akinsho @bryphe