Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

Conversation

akinsho
Copy link
Member

@akinsho akinsho commented Sep 24, 2018

This PR switches the grammar currently being used to the sane reasonml grammar

The reason being (excerpt from the new grammar's repo)

This is based on the grammar included in OCaml and Reason IDE, which unfortunately is hand-tuned in a rather haphazard way to be "optimized" for a few of the original author's preferred themes, to the detriment of everything else. This fork attempts to provide a more coherent grammar that properly distinguishes different tokens so that they can be properly selected for highlighting. In effect, this should provide a better default for most themes (except, of course, the select few the original grammar was hand-tuned for) and moves the repsonsibility of optimizing highlighting for specific languages from the grammar to each theme, where it should be to remain maintainable (and quite frankly just plain sane).

Having tested it out locally this seems to provide more regular and consistent highlighting, open to discussion though if any reason users disagree 👍

@codecov
Copy link

codecov bot commented Sep 24, 2018

Codecov Report

Merging #2579 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2579   +/-   ##
=======================================
  Coverage   45.41%   45.41%           
=======================================
  Files         353      353           
  Lines       14453    14453           
  Branches     1889     1889           
=======================================
  Hits         6564     6564           
  Misses       7665     7665           
  Partials      224      224

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bbb541...93f0811. Read the comment docs.

@bryphe
Copy link
Member

bryphe commented Sep 26, 2018

Sounds good to me, @akin909 ! Thank you! I had a few issues with the previous highlighting for Reason too 👍

@akinsho akinsho merged commit 8cdc82c into onivim:master Sep 26, 2018
@akinsho akinsho deleted the feature/switch-reasonml-grammar-to-sane-reasonml branch September 26, 2018 16:10
@akinsho akinsho restored the feature/switch-reasonml-grammar-to-sane-reasonml branch October 1, 2018 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants