Codecov Report

Merging #2531 into master will increase coverage by 0.2%.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##           master    #2531     +/-   ##
=========================================
+ Coverage   44.51%   44.71%   +0.2%     
=========================================
  Files         351      352      +1     
  Lines       14302    14318     +16     
  Branches     1865     1863      -2     
=========================================
+ Hits         6367     6403     +36     
+ Misses       7709     7689     -20     
  Partials      226      226

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5beff5f...711dccf. Read the comment docs.

I agree, for a coding tool it does not make sense to not be able to see dotfiles.

I would even argue that it should be on by default, but having the configuration is enough.

Any chance we can have this option to impact the File Explorer too? I can't edit important files such as .env, .rubocop.yml, etc..

I agree with @badosu this should be on by default imho 🤷‍♂️ (its very confusing behaviour that expected files are hidden in a code editor)

I added it as a config option based on the fact there was a TODO there for it, but now that I look at it, that TODO was added as part of refactoring the Quick Open menu out, such that it could be used for the "Find in files" functionality.

Perhaps @TalAmuyal could explain what they think is the best approach. Currently, I've just set it as a flag for both the QuickOpen and find in files (since I'd want it for both), but potentially that isn't the best approach?

I also noticed that as part of that PR, the "--case-sensitive" flag was removed, which I didn't think much of at the time, since I thought the filtering would help on our end, but I've now realised that its causing some weird results with the quick open as well....Maybe that should be reverted, since the results are less relevant, and also it gives Oni more files to process when the processing is fairly expensive.

EDIT:

For clarity, the --hidden flag will allow hidden folders/files to be seen, but since ripgrep uses a projects .gitignore by default, I don't see any issue with including it always? It would only show files the user wants to my knowledge. The only issue I can see is it may attempt to search the .git folder, but thats easily fixed with --glob "!.git/*" to not glob the git folder.

I also noticed that as part of that PR, the "--case-sensitive" flag was removed, which I didn't think much of at the time, since I thought the filtering would help on our end, but I've now realised that its causing some weird results with the quick open as well....Maybe that should be reverted, since the results are less relevant, and also it gives Oni more files to process when the processing is fairly expensive

See: #825

For clarity, the --hidden flag will allow hidden folders/files to be seen, but since ripgrep uses a projects .gitignore by default, I don't see any issue with including it always? It would only show files the user wants to my knowledge. The only issue I can see is it may attempt to search the .git folder, but thats easily fixed with --glob "!.git/*" to not glob the git folder

Yes, I think everyone agrees with having the hidden option, the proposal it being turned on by default.

I've swapped this over to enabled by default, but left the config option in "just in case".
I don't know of a reason why it wouldn't be needed..but still.

If @TalAmuyal is free anytime soon, it may be worth just waiting before merging to check I'm not being stupid here.

Should probably just get this merged since there has been no opposition, could I get a re-review?

@CrossR Can you describe this option in the wiki?

@badosu Done!