Feature/add git commit functionality #2441
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2441 +/- ##
==========================================
+ Coverage 42.62% 43.27% +0.64%
==========================================
Files 332 341 +9
Lines 13212 13425 +213
Branches 1736 1765 +29
==========================================
+ Hits 5632 5809 +177
- Misses 7302 7340 +38
+ Partials 278 276 -2
Continue to review full report at Codecov.
|
rename files in test and toggle functionality for commits
tidy up toggleAction to get state keys
| event.preventDefault() | ||
| currentWindow.webContents.send("open-oni-browser", url) | ||
| }) | ||
| if (!isDevelopment) { |
There was a problem hiding this comment.
This fixes a bug which was preventing hot reloading, since this was active in dev hot reloading would try to reopen index.html in oni's browser rather than letting electron reload the browser
|
@CrossR when youre able would love some feedback on this, it adds the ability to commit by hitting enter on a staged file or on the commit all row then renders a little spinner while that happens. Still leaving out the ui improvements till primer/octicons/pull/228 is merged |
|
@CrossR yeah I've decided to leave unstaging and uncommitting since this PR was already quite extensive 👍 but I've logged it and it's probably the next bit I'm going to work on. |
As part of fleshing out the VCS this pr adds the ability to commit a file using the git sidebar.
Additions:
Menu command toggle vcs visibility
Recent Commits Section: commits made whilst in oni (later might be preferable to get a git log rather than commits from oni)
Commiting: see below