This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Fix for #2251 Oni does not correctly locate executables #2440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the primary issue for me. $PATH in terminal nvim and oni are the same :) |
|
Cool, makes sense to me! There are cases on OSX where we don't pick up the shell environment - so this ensures we always have it. Thanks for the contribution @psxpaul ! 💯 And thanks @jordan-arenstein for testing it out, much appreciated. Bringing this in now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2251 doesn't appear to affect my linux system, but does affect my mac. I have tested this fix on both system, and it appears to fix the PATH issue for the mac.