Feature/render indent lines at correct levels #2433
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2433 +/- ##
=======================================
Coverage 38.28% 38.28%
=======================================
Files 300 300
Lines 12539 12539
Branches 1651 1651
=======================================
Hits 4801 4801
Misses 7483 7483
Partials 255 255Continue to review full report at Codecov.
|
There was a problem hiding this comment.
From a quick test, looks great! The lines seem to be the same as in VSCode now for me. (Actually from a second check....VSCode does have one for column 0. Though I'm less sure why that is useful? Unless I guess for files with a single class in so almost everything is indented)
One question though(which if needs action we can do in a separate PR!), is there a reason we have a list of allowed file-types for this? I think perhaps it was something to do with comment style, though I think that might not be needed now. I've tested this with LaTeX code as well with no issues, so wasn't sure.
|
@CrossR thanks for the review re. the 0 column tbh I was thinking that that would have to be configurable at some point as I can very easily see it being raised as an issue down the line since that behaviour isn't going to be universally expected I think users will probably want the option of choosing. Re. the file types I started off working off of how vim-indent-guides works and it gives a user the option to select per filetype tbh that list can probably be greatly expanded although I think its still very useful to be able to select where you want them to show as for example you might not want them in markdown (I know I wouldn't) or some other file for some other reason, without an option a user is stuck either turning them on or off with no more granular control |
@CrossR following our discussion a little while ago on discord I've tweaked the indent lines so they don't render a guide for the first level of indentation and the last resulting in:
Not sure if the image conveys the change correctly but the aim was to have indents render more in line with the way that sublime or vscode renders them as they seem not to render the first and the deepest level of indentation per line