This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Automation: Install tests (companion to #2372) #2378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2378 +/- ##
=========================================
+ Coverage 38.19% 38.3% +0.11%
=========================================
Files 300 300
Lines 12522 12540 +18
Branches 1649 1651 +2
=========================================
+ Hits 4783 4804 +21
+ Misses 7484 7481 -3
Partials 255 255
Continue to review full report at Codecov.
|
|
The caches on AppVeyor seem to keep failing.... no idea why, they just aren't being restored at all. That said, should be able to uncomment the final test now my PR is in. |
… now address that!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of some quick tests that validate the setup install / uninstall behavior (creating a directory, dropping an executable, running the uninstaller). It also queries the
PATHregistry key to check if it looks as expected. Hopefully it helps with validation for #2372 ! 💯