This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Electron: Use 'makeSingleInstance' API #2377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2377 +/- ##
=======================================
Coverage 38.11% 38.11%
=======================================
Files 300 300
Lines 12519 12519
Branches 1645 1645
=======================================
Hits 4771 4771
Misses 7494 7494
Partials 254 254Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: We were using our own implementation to mimic
makeSingleInstancefrom #679. This was because of electron/electron#9880, where the API was not working correctly on POSIX systems - it would hang and cause issues.Fix: It's preferable to use their system API instead of our own socket server for managing this. I suspect this could be a contributing factor to some of the automation hangs, in cases we're not cleaning up our server - so as opposed to maintaining our own strategy, we should switch back to the Electron API, now that the issue is addressed.