Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

Conversation

CrossR
Copy link
Member

@CrossR CrossR commented Jun 24, 2018

2 quick fixes for an error + bug when you have an empty workspace.

  1. An empty workspace caused the test file finding code to fail due to trying to concat a null, causing the command pallete to never open.
  2. The changes to file icons in the fuzzy finder broke the "Open Folder" and "Open Bookmarks" functionality. Swapped the file icon code to only apply to items that have an icon of type "file" now instead.

Neither of these happen very often, since we now set the workspace a lot more, but still awkward when they are hit.

@codecov
Copy link

codecov bot commented Jun 24, 2018

Codecov Report

Merging #2353 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2353   +/-   ##
=======================================
  Coverage   37.59%   37.59%           
=======================================
  Files         299      299           
  Lines       12464    12464           
  Branches     1643     1643           
=======================================
  Hits         4686     4686           
  Misses       7529     7529           
  Partials      249      249

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b15dce...e2ab603. Read the comment docs.

Copy link
Member

@bryphe bryphe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, @CrossR ! Looks good to me 👍

@CrossR CrossR merged commit d1a818e into onivim:master Jun 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants